feat: Change UI of new product type cards #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🥫 Product page
📈 Analytics
g123k
force-pushed
the
new-add-product-type
branch
from
4bc887b
to
7f95def
Compare
|
It's OK for me, but I prefer another review. |
g123k
requested review from
teolemon and
monsieurtanuki
and removed request for
g123k
There was a problem hiding this comment.
Hi @Valimp!
The UI looks OK. Please have a look at my comments.
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_page.dart
Outdated
Show resolved
Hide resolved
g123k
requested changes
Nov 19, 2024
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
g123k
requested changes
Nov 20, 2024
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
g123k
approved these changes
Nov 20, 2024
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/add_new_product/add_new_product_type.dart
Outdated
Show resolved
Hide resolved
|
Btw the code needs rebase. |
Valimp
force-pushed
the
new-add-product-type
branch
from
e90da50
to
39601a0
Compare
monsieurtanuki
approved these changes
Nov 23, 2024
|
Thanks for your first PR @Valimp 🎉 |
|
Thanks for helping me and reviewing my work @g123k @monsieurtanuki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes UI of cards on the page to add type to a product
Video
addProductPage.mp4
Screenshot
Light Mode
DarkMode
Part of