Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel cards need borders/shadows #5767

Closed
g123k opened this issue Oct 29, 2024 · 3 comments · Fixed by #5773
Closed

Carousel cards need borders/shadows #5767

g123k opened this issue Oct 29, 2024 · 3 comments · Fixed by #5773
Assignees

Comments

@g123k
Copy link
Collaborator

g123k commented Oct 29, 2024

Hi everyone,

We need a fix for:

  • Where are the borders of a card?
  • Is-this a button at the bottom?
  • WTF is that cross button in the middle of nowhere?

Image

@teolemon
Copy link
Member

Are you going straight for the poc design ?
Otherwise, do you keep a cross somewhere?

@g123k
Copy link
Collaborator Author

g123k commented Oct 29, 2024

No, this is for an intermediate release => improve as we can the current design.

@teolemon
Copy link
Member

ok, looks good for a drop shadow (we possibly removed it during the back and forth with the scanner)

@g123k g123k linked a pull request Nov 1, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants