Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sample product has been code normalized #5671

Open
teolemon opened this issue Oct 6, 2024 · 2 comments
Open

The sample product has been code normalized #5671

teolemon opened this issue Oct 6, 2024 · 2 comments
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Comments

@teolemon
Copy link
Member

teolemon commented Oct 6, 2024

What
@teolemon teolemon added 🐛 bug Something isn't working 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels Oct 6, 2024
@monsieurtanuki
Copy link
Contributor

@teolemon Not sure what we're supposed to do here.
A solution would be to get rid of that sample product. Wasn't that more or less planned in the big redesign @g123k?, cf. #4841
If needed I can blowtorch myself the onboarding in order to get rid of the sample product.
And then, when appropriate, the big redesign.

@teolemon
Copy link
Member Author

actually, it doesn't seem hard-coded, so possibly just merge the PR, and this will be fixed at the next release:

smooth-app/ci/update_assets.sh

Line 13 in 01402a6

PERFECT_PRODUCT_PATH="${SMOOTHIE_PATH}/assets/onboarding/sample_product_data.json"

@teolemon teolemon removed the 🐛 bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 💬 To discuss and validate
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @monsieurtanuki