Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes blocking the CI #5345

Closed
teolemon opened this issue Jun 8, 2024 · 3 comments · Fixed by #5346
Closed

Changes blocking the CI #5345

teolemon opened this issue Jun 8, 2024 · 3 comments · Fixed by #5346
Labels
release blocking issue

Comments

@teolemon
Copy link
Member

teolemon commented Jun 8, 2024 

          We're in trouble:

image

Any recent change in github's flutter version?

Originally posted by @monsieurtanuki in #5343 (comment)
@monsieurtanuki
Copy link
Contributor

If it could be avoided to merge code that fails that would be appreciated, cf #5332:
image

image

@monsieurtanuki monsieurtanuki linked a pull request Jun 8, 2024 that will close this issue
fix: 5345 #5346
Merged
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 8, 2024
@teolemon
Copy link
Member Author

teolemon commented Jun 8, 2024

I'm sorry, I merged during the weekly call, without making the verifications I should have

@monsieurtanuki
Copy link
Contributor

I'm sorry, I merged during the weekly call, without making the verifications I should have

I guess you have special powers that enable you to merge even faulty PRs.
With great power comes great responsibility. I guess weekly calls are your kryptonite 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release blocking issue
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 5345 monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki