Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I am getting disconnected as soon as I close the app #5217

Closed
teolemon opened this issue May 4, 2024 · 5 comments · Fixed by #5222
Closed

I am getting disconnected as soon as I close the app #5217

teolemon opened this issue May 4, 2024 · 5 comments · Fixed by #5222
Assignees
@monsieurtanuki
Labels
🐛 bug Something isn't working 🎯 P0 👥 User management Account login, signup, signout

Comments

@teolemon
Copy link
Member

teolemon commented May 4, 2024

What

  • I am getting disconnected as soon as I close the app

Steps to reproduce the behavior

  1. Go to the app, notice that you are disconnected
  2. Login successfully
  3. Close the app
  4. Open it again and notice that you are disconnected again

Context

  • we did some recent changes to the cookie system that might have had an impact on it ?
@teolemon teolemon added 🎯 P0 🐛 bug Something isn't working 👥 User management Account login, signup, signout labels May 4, 2024
@monsieurtanuki
Copy link
Contributor

we did some recent changes to the cookie system that might have had an impact on it ?

Probably related: in off-dart 3.7.0 I fixed a bug en passant about User in openfoodfacts/openfoodfacts-dart#920, more specifically about the cookie field being saved/retrieved by fromJson/toJson operations.

@monsieurtanuki
Copy link
Contributor

@teolemon Probably fixed by #5220.

@monsieurtanuki monsieurtanuki mentioned this issue May 5, 2024
Merged
@teolemon
Copy link
Member Author

teolemon commented May 5, 2024

Nope , still here @monsieurtanuki

@monsieurtanuki
Copy link
Contributor

@teolemon I'll have a look at it today.

@monsieurtanuki monsieurtanuki self-assigned this May 5, 2024
@monsieurtanuki
Copy link
Contributor

Unfortunately could not test today: it looks like my stupid mac book is not compatible with Android API 34. Which causes much delay - and the envy to throw this stupid computer once and for all and use a PC again.

@monsieurtanuki monsieurtanuki mentioned this issue May 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🐛 bug Something isn't working 🎯 P0 👥 User management Account login, signup, signout
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 5217 - no check on cookie as it's always null monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki