Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated text in onboarding #1934

Closed
teolemon opened this issue May 22, 2022 · 3 comments · Fixed by #1950
Closed

Duplicated text in onboarding #1934

teolemon opened this issue May 22, 2022 · 3 comments · Fixed by #1950
Assignees
@monsieurtanuki
Labels
food preferences 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Comments

@teolemon
Copy link
Member

What

  • Duplicated text in onboarding, this is due to the fact that we added a permanent text in the Food Preferences

Part of

Screenshot/Mockup/Before-After

image
@teolemon teolemon added food preferences 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels May 22, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon We need to get rid of one of the messages for the onboarding, right?
What do you prefer?

  1. keep only the first one, specific to onboarding
  2. keep only the second one, which is part of the normal preferences
  3. regardless, I would also suggest to get rid of the "reset food preferences" button during the onboarding - a bit too much to swallow at the same time

@teolemon
Copy link
Member Author

  1. The second one is more explicit (in its new rewording that was merged yesterday)
  2. Probably
    Bonus: enforcing only one section open at a time would be cool.

@monsieurtanuki monsieurtanuki self-assigned this May 23, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon OK then! (and the "only one section" is already in #1918) (as you know)

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue May 23, 2022
@monsieurtanuki
feat: openfoodfacts#1918 openfoodfacts#1934 - simplified user prefere…
eba879f 
…nces food

Deleted file:
* `abstract_collapsible_user_preferences.dart`: not really relevant anymore and source of confusion - the code was refactored to its only child, `UserPreferencesAttributeGroup`

Impacted files:
* `abstract_user_preferences.dart`: refactored without the "collapsed" option
* `Podfile.lock`: wtf
* `preferences_page.dart`: simplified the display (that was Scaffold^2)
* `project.pbxproj`: wtf
* `pubspec.lock`: wtf
* `user_preferences.dart`: added a setter/getter about the unique active attribute group
* `user_preferences_attribute_group.dart`: refactored around the unique active attribute group - no action and no icon for the only expanded group
* `user_preferences_food.dart`: removed doubled description and refresh button from onboarding
* `user_preferences_profile.dart`: unrelated minor refactoring
@monsieurtanuki monsieurtanuki mentioned this issue May 23, 2022
Merged
@teolemon teolemon moved this from To discuss and validate to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 24, 2022
monsieurtanuki added a commit that referenced this issue May 27, 2022
@monsieurtanuki @teolemon
feat: #1918 #1934 - simplified user preferences food (#1950)
e55c5ee 
* feat: #1918 #1934 - simplified user preferences food

Deleted file:
* `abstract_collapsible_user_preferences.dart`: not really relevant anymore and source of confusion - the code was refactored to its only child, `UserPreferencesAttributeGroup`

Impacted files:
* `abstract_user_preferences.dart`: refactored without the "collapsed" option
* `Podfile.lock`: wtf
* `preferences_page.dart`: simplified the display (that was Scaffold^2)
* `project.pbxproj`: wtf
* `pubspec.lock`: wtf
* `user_preferences.dart`: added a setter/getter about the unique active attribute group
* `user_preferences_attribute_group.dart`: refactored around the unique active attribute group - no action and no icon for the only expanded group
* `user_preferences_food.dart`: removed doubled description and refresh button from onboarding
* `user_preferences_profile.dart`: unrelated minor refactoring

* feat/#1918 - changed collapsed/expanded arrows for attribute groups

Deleted file:
* `smooth_animated_collapse_arrow.dart`

Impacted file:
* `user_preferences_attribute_group.dart`: changed collapsed/expanded arrows

* Update packages/smooth_app/ios/Podfile.lock

Co-authored-by: Pierre Slamich <[email protected]>

* Whatever works for that bloody github...

* Whatever works for that bloody github...

Co-authored-by: Pierre Slamich <[email protected]>
Repository owner moved this from In Progress to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 27, 2022
monsieurtanuki added a commit that referenced this issue May 27, 2022
@monsieurtanuki @teolemon @M123-dev
feat: #2001 - matched the figma mocks for the 6 onboarding pages (#2017)
b214d23 
* feat: #1918 #1934 - simplified user preferences food

Deleted file:
* `abstract_collapsible_user_preferences.dart`: not really relevant anymore and source of confusion - the code was refactored to its only child, `UserPreferencesAttributeGroup`

Impacted files:
* `abstract_user_preferences.dart`: refactored without the "collapsed" option
* `Podfile.lock`: wtf
* `preferences_page.dart`: simplified the display (that was Scaffold^2)
* `project.pbxproj`: wtf
* `pubspec.lock`: wtf
* `user_preferences.dart`: added a setter/getter about the unique active attribute group
* `user_preferences_attribute_group.dart`: refactored around the unique active attribute group - no action and no icon for the only expanded group
* `user_preferences_food.dart`: removed doubled description and refresh button from onboarding
* `user_preferences_profile.dart`: unrelated minor refactoring

* feat/#1918 - changed collapsed/expanded arrows for attribute groups

Deleted file:
* `smooth_animated_collapse_arrow.dart`

Impacted file:
* `user_preferences_attribute_group.dart`: changed collapsed/expanded arrows

* Update packages/smooth_app/ios/Podfile.lock

Co-authored-by: Pierre Slamich <[email protected]>

* feat: #2001 - matched the figma mocks for the first 5 onboarding pages

Deleted file:
* `scan_example.svg`

New files:
* `eco.svg`
* `globe.svg`
* `health.svg`
* `preferences.svg`
* `scan.svg`
* `title.svg`

Impacted files:
* `knowledge_panel_page_template.dart`: matched the figma mock; new parameters - svg asset and background color
* `next_button.dart`: matched the figma mock
* `onboarding_flow_navigator.dart`: added background color
* `preferences_page.dart`: matched the figma mock
* `sample_eco_card_page.dart`: new parameters - svg asset and background color
* `sample_health_card_page.dart`: new parameters - svg asset and background color
* `scan_example.dart`: matched the figma mock
* `welcome_page.dart`: matched the figma mock

* feat: #2001 - matched the figma mocks for the 6th onboarding page

New file:
* `analytics.svg`

Impacted files:
* `consent_analytics_page.dart`: matched the figma mock
* `onboarding_flow_navigator.dart`: minor refactoring

* github mess

* github mess

* Update packages/smooth_app/lib/pages/onboarding/consent_analytics_page.dart

Co-authored-by: Marvin M <[email protected]>

* Update packages/smooth_app/lib/pages/onboarding/next_button.dart

Co-authored-by: Marvin M <[email protected]>

* github mess

Co-authored-by: Pierre Slamich <[email protected]>
Co-authored-by: Marvin M <[email protected]>
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
food preferences 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #1918 #1934 - simplified user preferences food monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki