The default product in the onboarding is currently a bad one (Nutella ?) with not all panels available

[teolemon]

What

• The default product in the onboarding is currently a bad one (Nutella ?) with not all panels available
• Eg, the factory map is missing

Part of

• 🐣 The app should onboard users (Tracker) #561

[monsieurtanuki]

@teolemon Find a better product and give us its barcode.

[jasmeet0817]

Isn't this an issue on the backend ? We just request a product with example as product id.

[teolemon]

Yes, probably. I would have expected it to return the perfect product. I wasn't completely sure the client was doing the right thing already.

[monsieurtanuki]

Actually we don't need off's example to be perfect. Neither to use it.
All we need is a decent product, and its barcode.

@teolemon Would you like to play with barcodes: in demo mode, being able to set the onboarding barcode?

[jasmeet0817]

It's better to delegate this responsibility to BE, right now if we just query 1 barcode it might be a good product for Europe but not for America or Asia. The deal with Stephane was that BE will find the best fitting product and return that.

…

On Mon, 24 Jan 2022 at 11:45, monsieurtanuki ***@***.***> wrote: Actually we don't need off's example to be perfect. Neither to use it. All we need is a decent product, and its barcode. @teolemon <https://github.com/teolemon> Would you like to play with barcodes: in demo mode, being able to set the onboarding barcode? — Reply to this email directly, view it on GitHub <#1003 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZRHYQGJSCH5IV4SJCUTNLUXUUU7ANCNFSM5MTOF63A> . You are receiving this because you commented.Message ID: ***@***.***>

-- Cheers, Jasmeet Singh

[monsieurtanuki]

@jasmeet0817 That cannot indeed be the best fitting product for all the planet, and there's no country parameter for the example. We would need barcodes like example (master fallback), example-fr, example-us, ...
If the example changes, we should change the fallback data stored in assets, too.

[jasmeet0817]

don't we pass country as a cc parameter in the request to BE ? From barcode_product_query.dart we are passing ProductQuery.getCountry() as the country, I was assuming this translates to the country code being passed to BE.

[jasmeet0817]

@jasmeet0817 That cannot indeed be the best fitting product for all the planet, and there's no country parameter for the example. We would need barcodes like example (master fallback), example-fr, example-us, ... If the example changes, we should change the fallback data stored in assets, too.

For the fallback product, completely agreed that we can configure whatever product details that are best suited. But that we can fake.

Actually, the BE could also fake product details when example barcode is sent, in whichever language the request was sent in, let me check with Stephane, maybe that's what he was already planning

[stephanegigandet]

Right, the product you get back will depend on the country passed to the API.

[monsieurtanuki]

example is not only a wrong barcode, but some kind of meta barcode, then, whose product depends on the country?
We still need to find a global fallback product for the asset data.

[stephanegigandet]

Corresponding PR server side: openfoodfacts/openfoodfacts-server#6337

Only one product right now, but we can indeed have several if we want to change the production place. That will be done server side.

[stephanegigandet]

example is not only a wrong barcode, but some kind of meta barcode, then, whose product depends on the country?

That's correct.

For the fallback product, please use this one: https://world.openfoodfacts.org/product/093270067481501/a-good-product-for-you-open-food-facts

[jasmeet0817]

example is not only a wrong barcode, but some kind of meta barcode, then, whose product depends on the country?

I wouldn't say wrong it's a feature not a bug :) But yes, it's a meta barcode whose product depends on the country, that's why I think this bug belongs on the BE.

We still need to find a global fallback product for the asset data.

@teolemon what do you think about the fallback product, let us know if we should change that (or some aspects of that product)

[monsieurtanuki]

Screenshots with new fallback 093270067481501: