feat: copyWith methods for all classes
#853
Conversation
g123k
changed the title
copyWith methods for all classescopyWith methods for all classes
There was a problem hiding this comment.
Hi @g123k!
- I don't believe in "just in case" code, that nobody asked for and that
we'llI'll have to maintain, cf. here 38 files out of 39 - your implementation of
copyWithis misleading as you're not really copying data - that could be OK forintandStringbut not forMap<String, String>that is passed by reference
Example:
class Toto{
Map<String, String>? map;
Toto({this.map});
Toto copyWith({
Map<String, String>? map,
}) {
return Toto(
map: map ?? this.map,
);
}
}
void main() {
final Toto toto = Toto();
toto.map = {'a': 'toto'};
print(toto.map);
final Toto titi = toto.copyWith();
titi.map!['a'] = 'titi';
print(toto.map);
}Output:
{a: toto}
{a: titi}
That's partly why I used a combo of jsonDecode / jsonEncode to recreate objects from scratch. The second reason is that it's much easier to read and maintain. And performance is not an issue here.
|
True, you're right about the collections which are mutable. |
So you agree that your code contains bugs, right?
That's what I call "just in case" code, and I don't believe in it. Let's rather code "on demand": issues are made for that.
We agree that we disagree. If you need an additional reason NOT to do that: in the specific case of |
Hi everyone!
Instead of limiting ourselves to the
Productclass, I've added thecopyWithmethod to all classes, except when: