Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page that lists all Price tag proofs without any prices yet (= open for contribution) #1115

Closed
raphodn opened this issue Dec 11, 2024 · 3 comments
Labels

Comments

@raphodn
Copy link
Member

raphodn commented Dec 11, 2024

Story

Following changes in the backend - openfoodfacts/open-prices#568 - users are now allowed to add prices on PRICE_TAG proofs they do now own. Thus unlocking distributed contribution.

To kickstart this, we need a page that lists all available proofs open for contribution.

How

A list of all proofs that have the following caracteristics:

  • type = PRICE_TAG
  • price_count = 0
  • location_id__isnull = False

And clear actions for each proof :

  • view full size image
  • add prices
  • add prices via the contribution assistant

Questions

  • how to avoid users adding prices on the same proof ?
  • how to skip proofs that are unreable or without any barcodes displayed ?
    • allow users to tag proofs ?

Ideas

  • display proofs in a random order on each load, to mitigate the risk of having 2 users simultaneously adding prices on the same proof
@raphodn raphodn changed the title New page that lists all Price tag proofs without any prices yet New page that lists all Price tag proofs without any prices yet (= open for contribution) Dec 11, 2024
@raphael0202
Copy link
Contributor

Displaying proofs at random is enough for now! We should just keep in mind that SQL random() doesn't scale well to huge tables (as seen on Robotoff).
I wonder whether it's better to wait for openfoodfacts/open-prices#611 to be implemented in the backend, as it will make it easier from a front-end perspective:

  • fetch the price_tags with status=null randomly
  • annotate (using an interface similar to the 3rd step from the contribution assistant)
  • repeat

Another game could be to check that no bounding box (=item in the price_tag table) is missing, and if there are some, the user draw additional bounding boxes, which become available as new price_tags items to annotate.

@raphodn
Copy link
Member Author

raphodn commented Dec 11, 2024

I think in the meantime I'll just do a global "Latest proofs" page

@raphodn
Copy link
Member Author

raphodn commented Dec 14, 2024

closing as we'll wait a bit and build a "prices to validate list" instead of this "proofs to add list"

@raphodn raphodn closed this as completed Dec 14, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in 💸 Open Prices Dec 14, 2024
@raphodn raphodn removed the status in 💸 Open Prices Dec 14, 2024
@raphodn raphodn added the 🙅‍♀️ Wontfix This will not be worked on label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants