Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: double slash used as comments in example #27

Closed
2 tasks
Tracked by #126
adriantam opened this issue Jun 9, 2023 · 2 comments
Closed
2 tasks
Tracked by #126

README: double slash used as comments in example #27

adriantam opened this issue Jun 9, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@adriantam
Copy link
Member

Some of the README examples are incorrect in that double slash // are used in place of # as comments.

The offending lines are

Ideally, we will also fix the SDK generator here and here so that newly generated python SDKs will have the corresponding changes. This is tracked as openfga/sdk-generator#126. However, if that is difficult to do, simply focusing on the Python SDK side https://github.com/openfga/python-sdk/blob/main/README.md will help us as well.

@adriantam adriantam added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 9, 2023
@Harshal662
Copy link
Contributor

i can do that

@rhamzeh rhamzeh removed the bug Something isn't working label Jun 11, 2023
@rhamzeh
Copy link
Member

rhamzeh commented Jun 11, 2023

We have a PR (#30) fixing this already from another community member, but thank you for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants