Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxying. #16

Open
Sp3ctr3 opened this issue Dec 29, 2013 · 16 comments
Open

Add support for proxying. #16

Sp3ctr3 opened this issue Dec 29, 2013 · 16 comments
Labels

Comments

@Sp3ctr3
Copy link

Sp3ctr3 commented Dec 29, 2013

OpenFaux server already supports proxying. Add a feature that would read proxy IP from a configuration file, change the proxy to that address when the add-on is activated and reset it to normal configuration when it is deactivated. Optionally it could also have the ability to set the proxy by prompting the user for the address.

@zlatanvasovic
Copy link

What type of file should it be?

@nb333
Copy link
Member

nb333 commented Dec 29, 2013

@zdroid We just need the proxying to work and the proxy address should be modifiable.

@zlatanvasovic
Copy link

Ok. ;)

@nb333
Copy link
Member

nb333 commented Dec 29, 2013

@zdroid Can you help with this task? If so, I'll assign it to you.

@zlatanvasovic
Copy link

I can, but need some research.

My idea:

  1. Use file API to read .openfauxrc, or .openfaux.json (config should have JSON format).
  2. Load config.
  3. Implement it.

@nb333
Copy link
Member

nb333 commented Dec 30, 2013

@zdroid Look into FoxyProxy as sample code for Firefox plugins and the file API should work.

The final solution is that the extension should be able to switch the proxy address.

@juzerali
Copy link
Contributor

I didn't see an option to look at the source code of FoxyProxy.

@darkowlzz
Copy link
Contributor

@juzerali download the xpi and unzip it.

@juzerali
Copy link
Contributor

Did the original question ask to provide a configuration for changing the ip address of the server which will act as a proxy? It seems FoxyProxy doesn't read configuration from a file (from their UI). It provides a UI for entering the configuration and persists them using the persistence mechanism provided by the browser's extension API.

@zlatanvasovic
Copy link

Ok, then use inputs. File input was my idea. :O

2013/12/30 Juzer Ali [email protected]

Did the original question ask to provide a configuration for changing the
ip address of the server which will act as a proxy? It seems FoxyProxy
doesn't read configuration from a file (from their UI). It provides a UI
for entering the configuration and persists them using the persistence
mechanism provided by the browser's extension API.


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-31342067
.

Zlatan Vasović - ZDroid

@Sneezry
Copy link

Sneezry commented Dec 30, 2013

What type will the proxy server be? http/https/socks5/socks4? Or some of them?

ps. which browser is this issue related to? chrome or firefox?

@Sp3ctr3
Copy link
Author

Sp3ctr3 commented Dec 30, 2013

First priority would be an http proxy. This is already functioning. We are hoping to get TLS working on it soon.

@zlatanvasovic
Copy link

Ok then.

2013/12/30 Yashin Mehaboobe [email protected]

First priority would be an http proxy. This is already functioning. We are
hoping to get TLS working on it soon.


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-31343167
.

Zlatan Vasović - ZDroid

@darkowlzz
Copy link
Contributor

Lemme update you all with my progress and tell you what is working now.
This is for firefox jetpack add-on.
I hard coded a proxy address and port number. When the OpenFaux button is clicked, i.e. OpenFaux Activated, proxy set by us is used. And yes, we better keep the add-on Deactivated by default.
When the button is clicked again, proxy is disabled.

I have made it just for http right now. Easy to make for other protocols too, just add a few more lines for each protocol.
I am doing cleanup and writing code to enable the user to set the proxy address and port number in the add-on manager(Firefox again ;) ).

Let me know if anything I mentioned above is going away from what we need.

@zlatanvasovic
Copy link

@darkowlzz Good job.

@darkowlzz
Copy link
Contributor

Sorry for the delay. PR #36 sent!
Please try it out and file improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants