Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom IngressClass cannot be set for gateway ingress #1210

Closed
vkryzh opened this issue May 9, 2024 · 3 comments
Closed

Custom IngressClass cannot be set for gateway ingress #1210

vkryzh opened this issue May 9, 2024 · 3 comments

Comments

@vkryzh
Copy link

vkryzh commented May 9, 2024

IngressClass conflicts with the default annotation

Expected Behaviour

When IngressClass is set to custom value, it is working

Current Behaviour

When IngressClass is set to custom value, it is conflicting with default ingress annotation

Who is this for?

Corva

@vkryzh vkryzh changed the title Custom IngressClass cannot be set fir gateway ingress Custom IngressClass cannot be set for gateway ingress May 9, 2024
@alexellis
Copy link
Member

alexellis commented May 9, 2024

Hi @vkryzh

The issue template is not optional, but at times some fields may not apply. https://github.com/openfaas/faas-netes/blob/master/.github/ISSUE_TEMPLATE.md

Most importantly here, we need:

  • Steps to Reproduce (for bugs)

That should include showing us any ingress classes you have in your cluster, along with the name of the one you're trying to use for OpenFaaS.

To avoid too many round-tips, and clarifying questions on our part, please always include all the information we need to reproduce the issue you're facing. Your test system may differ from that of ours and other users.

As a general rule, we do not use the Ingress from the chart, but a separate definition which can be customised more easily. OpenFaaS Standard/Enterprise customers often also need additional ingress records for i.e. the dashboard, which are not part of the chart.

Alex

@alexellis
Copy link
Member

alexellis commented May 14, 2024

Since we didn't have any steps to reproduce the issue, I've tried to guess what you're trying to do.

https://docs.openfaas.com/tutorials/local-kind-ingress/

It seems to have adopted the Ingress Class:

kubectl get -n openfaas ingress
NAME               CLASS   HOSTS            ADDRESS   PORTS   AGE
openfaas-ingress   nginx   openfaas.local             80      20m

The chart sets this value in the correct place from what I can see in the template and the YAML inspected after running the above: https://github.com/openfaas/faas-netes/blob/master/chart/openfaas/templates/ingress.yaml#L21

In an example you sent me via email, I saw you used the ingressClassName and an annotation.

I don't think you're supposed to use the annotation anymore.. could that be the problem you're seeing?

@alexellis
Copy link
Member

Closing this issue since the ingress annotation is deprecated in Kubernetes, as linked above. No example was provided for reproducing the issue. I was able to show that ingressClassName is working as described in the Kubernetes documentation.

Feel free to comment here if you have further input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants