Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back 'xblockutils/base_test.py' #345

Closed
farhan opened this issue Jan 24, 2024 · 2 comments
Closed

Put back 'xblockutils/base_test.py' #345

farhan opened this issue Jan 24, 2024 · 2 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@farhan
Copy link
Contributor

farhan commented Jan 24, 2024

The initiator the task is this PR
Parent Story: openedx/XBlock#675

As the community is using base_test.py for plain selenium integration tests that was removed, so let's put it back.

Since base_test.py is tightly coupled with workbench, so lets move it into the xblock-sdk repo and combine it with test_utils.py which seems to have related functionality as suggested here

@farhan farhan converted this from a draft issue Jan 24, 2024
@farhan farhan self-assigned this Jan 24, 2024
@farhan farhan moved this from 📋 Backlog to 🔖 Ready in Aximprovements Team Jan 25, 2024
@farhan farhan moved this from 🔖 Ready to 🏗 In progress in Aximprovements Team Jan 25, 2024
@farhan
Copy link
Contributor Author

farhan commented Jan 25, 2024

xblockutils/base_test.py is extending from SeleniumTest class which is using bok-choy's WebAppTest class.

So it's linked to bok-choy library and I think we should keep it removed

@feanil what are your thoughts on it ?

@kdmccormick
Copy link
Member

Ah, I thought that workbench.test.selenium_test.SeleniumTest was a third-party library. I didn't realize that it actually comes from xblock-sdk and uses bok-choy.

I support keeping it removed 👍🏻 Thanks for looking into that @farhan .

@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Aximprovements Team Feb 7, 2024
@kdmccormick kdmccormick added the wontfix This will not be worked on label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Archived in project
Development

No branches or pull requests

2 participants