Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous String IDs in the various .js files in the repository are not properly harvested, collected and sent to Transifex for translations #24

Open
ehuthmacher opened this issue Feb 16, 2024 · 4 comments

Comments

@ehuthmacher
Copy link

ehuthmacher commented Feb 16, 2024

Relevant summary: https://discuss.openedx.org/t/translations-issues-with-the-frontend-app-learner-dashboard/12287

Issue: openedx/frontend-app-learner-dashboard#287

@ehuthmacher ehuthmacher converted this from a draft issue Feb 16, 2024
@ehuthmacher
Copy link
Author

Impacted resources: frontend-app-communications and frontend-app-learner-dashboard resources

@ehuthmacher
Copy link
Author

TX team can run tests to ensure that all strings defined in a particular resource are added to the strings that are sent to Transifex for translations - need source files for testing.

We can start running tests for frontend-app-communications and frontend-app-learner-dashboard and then test all MFE's for quality assurance.

@ehuthmacher
Copy link
Author

This will be an ongoing issue. Each repo maintainer will have to fix errors, as they are flagged. @brian-smith-tcril do you agree with this approach?

@brian-smith-tcril
Copy link

@OmarIthawi's solution proposed in the comment here openedx/frontend-app-learner-dashboard#287 (comment) will likely resolve a large proportion of the missing string issues.

I also agree we should make issues on repos where missing strings are found. It would be ideal to link to documentation so we don't need to repeat ourselves when explaining the problem and suggesting solutions. I think that documentation should likely live here https://docs.openedx.org/en/latest/translators/concepts/translation-process.html.

That being said, I don't think we can rely on repo maintainers to fix these issues. We should expect repo maintainers to keep translations in mind when reviewing PRs (to prevent new strings that aren't being picked up from being added), and to review and merge PRs that fix the existing issues in a timely manner, but I expect we will (realistically I will) need to dedicate some engineering effort to address the existing issues.

@ehuthmacher ehuthmacher moved this from In Progress to Done in Translations Working Group May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants