Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and improve event bus public how-to #238

Open
robrap opened this issue Jun 12, 2023 · 4 comments
Open

Move and improve event bus public how-to #238

robrap opened this issue Jun 12, 2023 · 4 comments
Labels
event-bus Work related to the Event Bus.

Comments

@robrap
Copy link
Contributor

robrap commented Jun 12, 2023

The Confluence event bus how-to should move to github, and could also be improved (as part of this ticket or a separate ticket).

Implementation details:

  • The Confluence doc has a variety of open comments. It would be simplest if these were either resolved and/or ticketed as-needed.
  • Recommend first moving the doc as-is to make it simpler to review changes. The initial PR (or possibly commit, but I prefer PR) should just require rST formatting review, but should not require re-reading the entire doc.
  • We'll need to decide if event-bus-kafka and event-bus-redis should have separate how-tos in their repos?
    • Pro: Engineers don't need to read about a technology that they don't need to deal with.
    • Con: Can this be done without making the how-to disjointed between docs, and minimizing duplication? Maybe it is ok to just duplicate.

Other improvements:

  • Note: Some of this might be ticketed separately.
  • The how-to currently mixes documentation types, and should be split, even if the how-to let's people know where to go to first understand background.
  • Can tips from Doc for writing brief and useful docs docs.openedx.org#338 shrink any paragraphs in the document?
    • Feedback: "Too much prose. Needs bullets and monospace."
  • Are there any code examples that can be copied directly into the doc, rather than (or in addition) to references via links? (This may no longer apply.)
  • The broken out Concept doc could do a better job helping someone with the minimum knowledge needed on hooks events to understand why signals are being used for an event bus consumer. (This feedback may be simpler when the signal listener is hidden for producing events.)
@robrap robrap added the event-bus Work related to the Event Bus. label Jun 12, 2023
@robrap robrap added this to Arch-BOM Jun 12, 2023
@robrap
Copy link
Contributor Author

robrap commented Jun 12, 2023

@navinkarkera @bmtcril: Not sure if you still have appetite for any of this work, but I finally created a ticket for this. This ticket could easily be broken into parts if need be.

@bmtcril
Copy link
Contributor

bmtcril commented Jun 13, 2023

@robrap I probably won't be able to take this on any time soon, and our contract with Navin / OpenCraft is wrapping up once the events-as-config work is done. However as a newly minted core contributor he could pick it up if OC thinks it's a good use of his hours. 😄

@robrap
Copy link
Contributor Author

robrap commented Jun 13, 2023

Thanks @bmtcril. Good to know that project is coming to a close. I've got a number of potential onboarding improvement tickets, if and when anyone working with the event bus wants to help make some advancements.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Nov 4, 2024

@robrap: I'll be working on a docs FC project which aims to include event bus docs from confluence into the repo as one of its features: https://docs.google.com/document/d/1_kU-Rp0KS8XDNNeQnVAjAz4Cqpc_665XMVQ6BuCeNio/edit?tab=t.0#heading=h.1hnlfb82j24c

I'm not sure how much I could take on from this issue, but I'll make sure to review it before moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-bus Work related to the Event Bus.
Projects
None yet
Development

No branches or pull requests

3 participants