Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check app domain #119

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: check app domain #119

merged 1 commit into from
Sep 27, 2023

Conversation

zacharis278
Copy link
Contributor

@zacharis278 zacharis278 commented Sep 27, 2023

Fixes a bug in #116

The domain for this message should actually match the current page. This differs from the Proctorio docs a bit since they are customizing the domain on the extension to match the edX learning app.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (60cdeb6) 94.09% compared to head (3acf093) 94.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          71       71           
  Lines        1050     1050           
  Branches      288      288           
=======================================
  Hits          988      988           
  Misses         57       57           
  Partials        5        5           
Files Coverage Δ
src/data/messages/proctorio.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharis278 zacharis278 merged commit 0bb36d4 into main Sep 27, 2023
6 checks passed
@zacharis278 zacharis278 deleted the zhancock/fix-message-domain branch September 27, 2023 15:57
@github-actions
Copy link

🎉 This PR is included in version 2.23.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants