Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8400] Add subtitle facet to search header #382

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Mar 25, 2024

Description

Adds a "Subtitle" facet dropdown to the search header that corresponds to the transcript_languages attribute in Algolia to filter out the courses that have video transcripts associated with them.

Ticket

ENT-8400

Screenshot 2024-03-25 at 4 24 22 PM image

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

@mahamakifdar19 mahamakifdar19 changed the title feat: add subtitle facet to SearchHeader [ENT-8400]: add subtitle facet to SearchHeader Mar 25, 2024
@mahamakifdar19 mahamakifdar19 changed the title [ENT-8400]: add subtitle facet to SearchHeader [ENT-8400] Add subtitle facet to search header Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (83e8405) to head (fc6d981).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   78.67%   79.08%   +0.40%     
==========================================
  Files          35       35              
  Lines         694      698       +4     
  Branches      177      179       +2     
==========================================
+ Hits          546      552       +6     
+ Misses        135      133       -2     
  Partials       13       13              
Files Coverage Δ
packages/catalog-search/src/config/index.js 100.00% <100.00%> (ø)
packages/catalog-search/src/data/constants.js 100.00% <100.00%> (+7.14%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e8405...fc6d981. Read the comment docs.

@mahamakifdar19 mahamakifdar19 marked this pull request as draft March 25, 2024 12:14
@mahamakifdar19 mahamakifdar19 marked this pull request as ready for review March 26, 2024 09:14
@mahamakifdar19 mahamakifdar19 merged commit 047844f into master Mar 29, 2024
10 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-8400 branch March 29, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants