Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bumped frontend-platform to v6 #364

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Oct 17, 2023

Description
Bumped frontend-platform to v6 which includes major version upgrades bumping paragon to v21, react-redux to v8.1.1 & react-intl to v6.4.7

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

@BilalQamar95 BilalQamar95 self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9866f7) 78.31% compared to head (e6cff62) 78.31%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   78.31%   78.31%           
=======================================
  Files          34       34           
  Lines         664      664           
  Branches      170      170           
=======================================
  Hits          520      520           
  Misses        131      131           
  Partials       13       13           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1413ef2...e6cff62. Read the comment docs.

@BilalQamar95 BilalQamar95 marked this pull request as draft November 17, 2023 13:22
@BilalQamar95 BilalQamar95 marked this pull request as ready for review November 17, 2023 13:22
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/frontend-platform-upgrade branch 2 times, most recently from 5951743 to e6cff62 Compare December 1, 2023 08:26
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/frontend-platform-upgrade branch from 0e967f8 to e6cff62 Compare December 21, 2023 13:13
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so long as it's verified that consumers of these NPM packages can still either use v5 or v6 of frontend-platform given both are listed as possible peer dependencies. Based on the release notes for v6 frontend-platform, seems like it should be a non-issue to support both here (no breaking change needed?).

@BilalQamar95
Copy link
Contributor Author

LGTM, so long as it's verified that consumers of these NPM packages can still either use v5 or v6 of frontend-platform given both are listed as possible peer dependencies. Based on the release notes for v6 frontend-platform, seems like it should be a non-issue to support both here (no breaking change needed?).

I don't think a breaking change is needed here, we also did do some preliminary consumer testing & they were working fine

@BilalQamar95 BilalQamar95 merged commit 1541b86 into master Jan 11, 2024
18 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/frontend-platform-upgrade branch January 11, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants