-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bumped frontend-platform to v6 #364
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #364 +/- ##
=======================================
Coverage 78.31% 78.31%
=======================================
Files 34 34
Lines 664 664
Branches 170 170
=======================================
Hits 520 520
Misses 131 131
Partials 13 13 Continue to review full report in Codecov by Sentry.
|
5951743
to
e6cff62
Compare
0e967f8
to
e6cff62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, so long as it's verified that consumers of these NPM packages can still either use v5 or v6 of frontend-platform given both are listed as possible peer dependencies. Based on the release notes for v6 frontend-platform, seems like it should be a non-issue to support both here (no breaking change needed?).
I don't think a breaking change is needed here, we also did do some preliminary consumer testing & they were working fine |
Description
Bumped frontend-platform to v6 which includes major version upgrades bumping
paragon
tov21
,react-redux
tov8.1.1
&react-intl
tov6.4.7
Merge checklist:
frontend-app-learner-portal-enterprise
,frontend-app-admin-portal
, andfrontend-app-enterprise-public-catalog
). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGE
so the NPM package is released as such.Post merge:
chore(release): publish
) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.Publish from package.json
Github Action workflow to publish these new package versions to NPM.master
branch.npm view <package_name> versions --json
).