revert: "chore(deps): update dependency @testing-library/react to v14" #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 51 51
Lines 849 849
Branches 176 176
=======================================
Hits 567 567
Misses 272 272
Partials 10 10 ☔ View full report in Codecov by Sentry. |
This reverts commit a3611b0. This version of `testing-library/react` doesn't play well with our current version of React. We shouldn't upgrade this library until we're running a newer version of React in this MFE.
justinhynes
force-pushed
the
jhynes/revert_react-testing-library-upgrade
branch
from
9b009e9 to
10e55ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a3611b0. This version of
testing-library/reactdoesn't play well with our current version of React.We shouldn't upgrade this library until we're running a newer version of React in this MFE.