Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update paragon and frontend-build in profile #975

Closed

Conversation

Yagnesh1998
Copy link

There is an edx organization on NPM that currently publishes many packages. An organization can't be renamed but there is a process for moving packages between organizations. The edx organization or scope as NPM calls it, has both packages that are a part of the Open edX ecosystem as well as packages that are specific to edx.org. To reduce confusion we'll be moving the openedx packages to a new openedx scope in NPM.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 27, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Yagnesh1998! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 27, 2024
@arbrandes
Copy link
Contributor

@Yagnesh1998, mind resolving conflicts? Thanks!

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (89bccea) to head (87f8f8a).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files          51       51           
  Lines         849      849           
  Branches      176      176           
=======================================
  Hits          567      567           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 29, 2024
@arbrandes arbrandes self-requested a review March 6, 2024 13:08
@jsnwesson jsnwesson added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Mar 6, 2024
@jsnwesson
Copy link
Contributor

Just noting this for Aperture's review since this might require a follow-up change in our stage/prod build config once this is merged.

package.json Outdated Show resolved Hide resolved
@deborahgu deborahgu requested a review from arbrandes March 14, 2024 19:01
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand the decisions, here.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@justinhynes
Copy link
Contributor

@Yagnesh1998 Just another bump requesting conflict resolution. Would you be able to address any of the questions/comments on the PR too? TIA!

@deborahgu deborahgu added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 11, 2024
@deborahgu
Copy link
Member

@Yagnesh1998 is this PR still in process? Will you be able to resolve the conflicts?

@arbrandes I am pretty sure that @Yagnesh1998 resolved your questions (by fixing the accidentally downgraded packages); am I correct?

@Yagnesh1998
Copy link
Author

Yagnesh1998 commented Apr 11, 2024

@deborahgu & @justinhynes Of course I will. thanks for reminding.
But I have a question when I did this last time there was no Conflict.So when the PR is not merged until the issue comes up again i assuming

@justinhynes
Copy link
Contributor

Hi @Yagnesh1998,

I am on call for Aperture this week and was following up on this PR. I noticed that another PR came through that updated paragon and frontend-build. I think this PR becomes a bit redundant now.

Sorry for any confusion. I am going to close this PR for now, but please feel free to re-open or let me know if I got something wrong. All the best.

@openedx-webhooks
Copy link

@Yagnesh1998 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-webhooks
Copy link

@Yagnesh1998 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer. open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants