-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update paragon and frontend-build in profile #975
Conversation
Thanks for the pull request, @Yagnesh1998! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@Yagnesh1998, mind resolving conflicts? Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 51 51
Lines 849 849
Branches 176 176
=======================================
Hits 567 567
Misses 272 272
Partials 10 10 ☔ View full report in Codecov by Sentry. |
Just noting this for Aperture's review since this might require a follow-up change in our stage/prod build config once this is merged. |
edbf84d
to
1b133bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand the decisions, here.
@Yagnesh1998 Just another bump requesting conflict resolution. Would you be able to address any of the questions/comments on the PR too? TIA! |
@Yagnesh1998 is this PR still in process? Will you be able to resolve the conflicts? @arbrandes I am pretty sure that @Yagnesh1998 resolved your questions (by fixing the accidentally downgraded packages); am I correct? |
@deborahgu & @justinhynes Of course I will. thanks for reminding. |
Hi @Yagnesh1998, I am on call for Aperture this week and was following up on this PR. I noticed that another PR came through that updated Sorry for any confusion. I am going to close this PR for now, but please feel free to re-open or let me know if I got something wrong. All the best. |
@Yagnesh1998 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
@Yagnesh1998 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
There is an edx organization on NPM that currently publishes many packages. An organization can't be renamed but there is a process for moving packages between organizations. The edx organization or scope as NPM calls it, has both packages that are a part of the Open edX ecosystem as well as packages that are specific to edx.org. To reduce confusion we'll be moving the openedx packages to a new openedx scope in NPM.