feat: hide username from profile page #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## simplify-registration #966 +/- ##
=========================================================
+ Coverage 66.82% 67.09% +0.27%
=========================================================
Files 52 52
Lines 850 857 +7
Branches 176 178 +2
=========================================================
+ Hits 568 575 +7
Misses 272 272
Partials 10 10 ☔ View full report in Codecov by Sentry. |
attiyaIshaque
force-pushed
the
attiya/VAN-1834-remove-username
branch
2 times, most recently
from
5a2fe2e to
9612bfa
Compare
attiyaIshaque
changed the title
attiyaIshaque
force-pushed
the
attiya/VAN-1834-remove-username
branch
3 times, most recently
from
f0540a5 to
e99d11f
Compare
attiyaIshaque
force-pushed
the
attiya/VAN-1834-remove-username
branch
from
e99d11f to
3d6e6b9
Compare
attiyaIshaque
force-pushed
the
attiya/VAN-1834-remove-username
branch
from
3d6e6b9 to
28ea404
Compare
zainab-amir
approved these changes
Feb 23, 2024
zainab-amir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Username visibility on the profile page is determined by the backend settings feature flag
ENABLE_AUTO_GENERATED_USERNAME. IfautoGeneratedUsernameEnabledis true then it will display the first name and last name initial of the user.https://2u-internal.atlassian.net/browse/VAN-1834
Screenshots