Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace legacy LMS url with account and profile mfe urls #928

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

Mashal-m
Copy link
Contributor

No description provided.

@Mashal-m Mashal-m marked this pull request as draft November 29, 2023 10:46
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (fecfdc1) to head (a70a3a7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files          52       52           
  Lines         850      850           
  Branches      176      176           
=======================================
  Hits          568      568           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m changed the title feat: replace legacy LMS url with account mfe url feat: replace legacy LMS url with account and profile mfe urls Nov 30, 2023
@justinhynes
Copy link
Contributor

Hi @Mashal-m -- is this something you are currently working on? If not, can we close this PR until it is prioritized again?

@abdullahwaheed abdullahwaheed marked this pull request as ready for review March 4, 2024 13:01
@abdullahwaheed
Copy link
Contributor

abdullahwaheed commented Mar 4, 2024

Hi @Mashal-m -- is this something you are currently working on? If not, can we close this PR until it is prioritized again?

@justinhynes this PR is ready for review and merging

@arbrandes arbrandes merged commit b13c26b into master Mar 4, 2024
9 checks passed
@arbrandes arbrandes deleted the mashal-m/update-account-setting-url branch March 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants