Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fields visibility and visibility forms #921

Conversation

vladislavkeblysh
Copy link
Contributor

  • Fixed the display of fields in a user's profile when viewing it from our own account to another user's profile that was just created (by default, the fields Full name, Location, and Certificates (if any) are displayed).
  • Fixed the display of empty fields in a user's profile when viewing it from our own account to another user's profile that was just created. Fields that are not filled in will not be displayed (previously, if a field was not filled in, the field name was displayed, but not the value).
  • Fixed the behavior of forms for a newly created user. Previously, if you changed the value of one field to Just me for the first time, the values of other fields were also reset to Just me. Now, only the value of the edited field is changed.

Screenshot 2023-10-10 at 15 09 45
Screenshot 2023-10-10 at 15 10 11
Screenshot 2023-10-10 at 15 10 02

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 25, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vladislavkeblysh
Copy link
Contributor Author

This changes already was merged in master and palm.master.

Please check MR on quince.master

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 27, 2023
@justinhynes
Copy link
Contributor

@vladislavkeblysh -- looks like we have some test failures here, could you take a look?

@justinhynes justinhynes added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 28, 2023
@vladislavkeblysh
Copy link
Contributor Author

@justinhynes This error is not related to the new code added in this PR, i think.
It seems like this has been carrying over from previous PRs.

@justinhynes
Copy link
Contributor

@vladislavkeblysh I'm a bit confused. I'm looking at the four most recent merges to the quince.master branch, and it looks like the tests were passing after each commit. I'm not sure I understand what you mean that this is carried over from a previous PR.

I'll poke around some more.

@vladislavkeblysh
Copy link
Contributor Author

@justinhynes I will look on tests again also

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@20c9595). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #921   +/-   ##
=============================================================
  Coverage                              ?   66.82%           
=============================================================
  Files                                 ?       52           
  Lines                                 ?      850           
  Branches                              ?      176           
=============================================================
  Hits                                  ?      568           
  Misses                                ?      272           
  Partials                              ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladislavkeblysh
Copy link
Contributor Author

@justinhynes Tests fixed. Sorry for the waiting

@justinhynes
Copy link
Contributor

I'll take another look at this today. Thanks for the heads up on the update. :)

@justinhynes justinhynes removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 4, 2024
@justinhynes justinhynes merged commit ac277ee into openedx:open-release/quince.master Jan 4, 2024
9 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants