-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fields visibility and visibility forms #921
feat: Fields visibility and visibility forms #921
Conversation
vladislavkeblysh
commented
Nov 25, 2023
- Fixed the display of fields in a user's profile when viewing it from our own account to another user's profile that was just created (by default, the fields Full name, Location, and Certificates (if any) are displayed).
- Fixed the display of empty fields in a user's profile when viewing it from our own account to another user's profile that was just created. Fields that are not filled in will not be displayed (previously, if a field was not filled in, the field name was displayed, but not the value).
- Fixed the behavior of forms for a newly created user. Previously, if you changed the value of one field to Just me for the first time, the values of other fields were also reset to Just me. Now, only the value of the edited field is changed.
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
This changes already was merged in master and palm.master. Please check MR on quince.master |
@vladislavkeblysh -- looks like we have some test failures here, could you take a look? |
@justinhynes This error is not related to the new code added in this PR, i think. |
@vladislavkeblysh I'm a bit confused. I'm looking at the four most recent merges to the I'll poke around some more. |
@justinhynes I will look on tests again also |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #921 +/- ##
=============================================================
Coverage ? 66.82%
=============================================================
Files ? 52
Lines ? 850
Branches ? 176
=============================================================
Hits ? 568
Misses ? 272
Partials ? 10 ☔ View full report in Codecov by Sentry. |
@justinhynes Tests fixed. Sorry for the waiting |
I'll take another look at this today. Thanks for the heads up on the update. :) |
ac277ee
into
openedx:open-release/quince.master
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |