Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove scrollbars #920

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

MaxFrank13
Copy link
Member

@MaxFrank13 MaxFrank13 commented Nov 22, 2023

This adds overflow: hidden; to the wrapper for the Plugin to hide scrollbars that will flicker when resizing.

@MaxFrank13 MaxFrank13 force-pushed the mfrank/remove-scrollbars branch from bb093fd to a8b803d Compare November 22, 2023 16:17
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (aperture/PluginPOCFeature@2fa5cad). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             aperture/PluginPOCFeature     #920   +/-   ##
============================================================
  Coverage                             ?   63.66%           
============================================================
  Files                                ?       54           
  Lines                                ?      856           
  Branches                             ?      161           
============================================================
  Hits                                 ?      545           
  Misses                               ?      301           
  Partials                             ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@cdeery cdeery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I hope that clears up the problem!

@MaxFrank13 MaxFrank13 merged commit ad80493 into aperture/PluginPOCFeature Nov 22, 2023
9 checks passed
@MaxFrank13 MaxFrank13 deleted the mfrank/remove-scrollbars branch November 22, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants