Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fields visibility and visibility forms (palm.master) #865

Conversation

vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Oct 10, 2023

  • Fixed the display of fields in a user's profile when viewing it from our own account to another user's profile that was just created (by default, the fields Full name, Location, and Certificates (if any) are displayed).
  • Fixed the display of empty fields in a user's profile when viewing it from our own account to another user's profile that was just created. Fields that are not filled in will not be displayed (previously, if a field was not filled in, the field name was displayed, but not the value).
  • Fixed the behavior of forms for a newly created user. Previously, if you changed the value of one field to Just me for the first time, the values of other fields were also reset to Just me. Now, only the value of the edited field is changed.

Screenshot 2023-10-10 at 15 09 45
Screenshot 2023-10-10 at 15 10 11
Screenshot 2023-10-10 at 15 10 02

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vladislavkeblysh vladislavkeblysh changed the title feat: Fields visibility and visibility forms feat: Fields visibility and visibility forms (palm.master) Oct 10, 2023
@vladislavkeblysh vladislavkeblysh marked this pull request as draft October 10, 2023 11:45
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review October 10, 2023 12:12
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@e0d
Copy link

e0d commented Oct 10, 2023

@vladislavkeblysh seeing some linting fallures.

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b533bf7) 65.36% compared to head (2621f68) 65.99%.
Report is 3 commits behind head on open-release/palm.master.

❗ Current head 2621f68 differs from pull request most recent head c0d8440. Consider uploading reports for the commit c0d8440 to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/palm.master     #865      +/-   ##
============================================================
+ Coverage                     65.36%   65.99%   +0.63%     
============================================================
  Files                            51       51              
  Lines                           820      847      +27     
  Branches                        158      176      +18     
============================================================
+ Hits                            536      559      +23     
- Misses                          274      278       +4     
  Partials                         10       10              
Files Coverage Δ
src/profile/ProfilePage.jsx 85.71% <100.00%> (+4.83%) ⬆️
src/profile/data/constants.js 100.00% <ø> (ø)
src/profile/data/selectors.js 91.58% <100.00%> (+0.16%) ⬆️
src/profile/data/sagas.js 58.44% <50.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/visibility-form-fields-palm.master branch from 2621f68 to c0d8440 Compare October 26, 2023 10:38
@vladislavkeblysh
Copy link
Contributor Author

@e0d Fixed

@justinhynes
Copy link
Contributor

I'll be taking a look at this today.

@justinhynes justinhynes merged commit 9461973 into openedx:open-release/palm.master Nov 8, 2023
5 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants