Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add ID attribute to the main content #845

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: Add ID attribute to the main content #845

merged 1 commit into from
Oct 16, 2023

Conversation

Lunyachek
Copy link
Contributor

Added the missing 'ID' parameter for the main section. When we want to use keyboard navigation through the page, the first anchor we encounter on the account page is 'Skip to main content,' which allows us to skip the header and move to the content area. However, this anchor is linked to the #main ID, which is missing in the main section.

Before fix:

2023-09-19.11.10.45.mov

After:

2023-09-19.11.09.50.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 19, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e770101) 66.22% compared to head (1fe8404) 66.22%.
Report is 8 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files          52       52           
  Lines         823      823           
  Branches      158      158           
=======================================
  Hits          545      545           
  Misses        268      268           
  Partials       10       10
Files Coverage Δ
src/index.jsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@mphilbrick211 mphilbrick211 requested a review from a team October 10, 2023 18:38
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@mphilbrick211
Copy link

Hi @openedx/2u-aperture! This is ready for review. Thanks!

@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Oct 12, 2023
@hurtstotouchfire
Copy link
Member

Hi @mphilbrick211 For anything we need to review, if you add the needs maintainer attention label we will put it through our triage process.

@justinhynes justinhynes self-assigned this Oct 16, 2023
@justinhynes
Copy link
Contributor

I should be taking a look at this later today.

@justinhynes justinhynes merged commit 8f6b969 into openedx:master Oct 16, 2023
8 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

jsnwesson added a commit that referenced this pull request Oct 18, 2023
@jsnwesson
fix: rebase pluginPOCFeature with master branch (#884)
2fa5cad 
* fix(deps): update dependency @edx/paragon to v20.46.3

* chore(deps): update commitlint monorepo to v17.8.0

* fix(deps): update dependency @edx/frontend-component-footer to v12.4.0

* chore: bump frontend-platform (#869)

* fix: Add ID attribute to the main content (#845)

* chore: update browserslist DB (#871)

* fix(deps): update dependency @edx/frontend-platform to v5.6.1 (#875)

* build(deps): bump @babel/traverse from 7.22.5 to 7.23.2 (#879)

* bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2.

* fix(deps): update dependency core-js to v3.33.0 (#876)
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
@Lunyachek Lunyachek deleted the lunyachek/fix/add-id-main-content branch March 25, 2024 21:07
@Lunyachek Lunyachek restored the lunyachek/fix/add-id-main-content branch March 25, 2024 21:27
@Lunyachek Lunyachek mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinhynes justinhynes justinhynes approved these changes

Assignees

@justinhynes justinhynes

Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer. open-source-contribution PR author is not from Axim or 2U
Projects
Aperture-Maintained
Status: Done
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Lunyachek @openedx-webhooks @mphilbrick211 @hurtstotouchfire @justinhynes @itsjeyd @e0d