-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade react router to v6 #716
Conversation
Thanks for doing this! As a result of #718, we have updated how the |
79aa9cc
to
6ea6c30
Compare
379005a
to
2e8bdf7
Compare
… Ali-Abbas/react-router-upgrade
… Ali-Abbas/react-router-upgrade
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 66.09% 66.22% +0.12%
==========================================
Files 51 52 +1
Lines 820 823 +3
Branches 158 158
==========================================
+ Hits 542 545 +3
Misses 268 268
Partials 10 10
☔ View full report in Codecov by Sentry. |
@Syed-Ali-Abbas-Zaidi There are still some conflicts in this PR. If we can get those resolved I can prioritize reviewing and merging the changes. Thanks! |
… Ali-Abbas/react-router-upgrade
I have resolved the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have also merged the internal PR for the profile MFE.
We need to merge this edge-PR too, so that it can also be deployed on edge as well. |
Ticket
React Router Upgrade to v6.
Description
This PR upgrades React Router from
v5
tov6
.