Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #716

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Mar 17, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Mar 17, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft March 17, 2023 06:51
@MaxFrank13
Copy link
Member

Thanks for doing this! As a result of #718, we have updated how the Routes are configured in this MFE

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch from 79aa9cc to 6ea6c30 Compare April 6, 2023 09:18
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (a0fd863) 66.09% compared to head (95675a1) 66.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   66.09%   66.22%   +0.12%     
==========================================
  Files          51       52       +1     
  Lines         820      823       +3     
  Branches      158      158              
==========================================
+ Hits          542      545       +3     
  Misses        268      268              
  Partials       10       10              
Files Changed Coverage Δ
src/profile/ProfilePage.jsx 80.88% <100.00%> (ø)
src/routes/AppRoutes.jsx 100.00% <100.00%> (ø)
src/utils/hoc.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 18, 2023 08:39
@justinhynes
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi There are still some conflicts in this PR. If we can get those resolved I can prioritize reviewing and merging the changes. Thanks!

@Syed-Ali-Abbas-Zaidi
Copy link
Contributor Author

@Syed-Ali-Abbas-Zaidi There are still some conflicts in this PR. If we can get those resolved I can prioritize reviewing and merging the changes. Thanks!

I have resolved the conflicts.

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have also merged the internal PR for the profile MFE.

@justinhynes justinhynes merged commit fe800f2 into master Sep 5, 2023
7 checks passed
@justinhynes justinhynes deleted the Ali-Abbas/react-router-upgrade branch September 5, 2023 18:55
@Syed-Ali-Abbas-Zaidi
Copy link
Contributor Author

LGTM. I have also merged the internal PR for the profile MFE.

We need to merge this edge-PR too, so that it can also be deployed on edge as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants