fix: Use Paragon Tab Component #1448

qasimgulzar · 2024-08-27T10:02:21Z

tabs-demo.mov

Click here to check original github issue

openedx-webhooks · 2024-08-27T10:02:25Z

Thanks for the pull request, @qasimgulzar!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

open-craft-grove · 2024-09-06T16:03:35Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

qasimgulzar · 2024-09-06T17:20:35Z

Noted broken tests, I will be taking care of it

itsjeyd · 2024-09-07T09:24:51Z

@qasimgulzar Just to understand better, does this PR change any user-facing functionality? Or does it just change the way that existing functionality is implemented?

If it's the former, it would likely be necessary to get product approval before moving forward with engineering review here.

CC @openedx/committers-frontend-app-learning @brian-smith-tcril

open-craft-grove · 2024-09-15T19:29:46Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

qasimgulzar · 2024-09-16T09:20:45Z

@qasimgulzar Just to understand better, does this PR change any user-facing functionality? Or does it just change the way that existing functionality is implemented?

If it's the former, it would likely be necessary to get product approval before moving forward with engineering review here.

CC @openedx/committers-frontend-app-learning @brian-smith-tcril

It is not actually changing the functionality or the use experience. It is just to replace the navigation component with Paragon's Tab component.

open-craft-grove · 2024-09-16T17:51:09Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

itsjeyd · 2024-09-20T12:33:05Z

@qasimgulzar I see, thanks for the info. No need to send this PR through the product review process then.

Let us know when the build is green so we can get started with engineering review.

open-craft-grove · 2024-09-24T10:48:26Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bradenmacdonald · 2024-09-24T17:59:27Z

src/pages/courseware/components.jsx

+  // unitId: PropTypes.string,
+};
+
+export default injectIntl(CoursewarePage);


This is minor, but please use useIntl(); instead of injectIntl in any new components, and avoid defining defaultProps which is deprecated in React for function components.

bradenmacdonald · 2024-09-24T17:59:36Z

src/pages/courseware/components.jsx

+        <Tabs
+          variant="tabs"
+          defaultActiveKey={activeKey}
+          id="uncontrolled-tab-example"


This id seems wrong?

bradenmacdonald · 2024-09-24T17:59:56Z

src/pages/courseware/components.jsx

+      </main>
+
+      {/* courseStatus 'failed' and any other unexpected course status. */}
+      {(!['loading', 'loaded', 'denied'].includes(courseStatus)) && (


Can these 'loading', 'loaded', 'denied' be loaded from an enum or constant somewhere?

codecov · 2024-09-24T18:02:22Z

Codecov Report

Attention: Patch coverage is 59.64912% with 23 lines in your changes missing coverage. Please review.

Project coverage is 88.28%. Comparing base (5ae8646) to head (ce82ded).
Report is 77 commits behind head on master.

Files with missing lines	Patch %	Lines
src/pages/courseware/components.jsx	61.53%	20 Missing ⚠️
src/course-home/discussion-tab/DiscussionTab.jsx	0.00%	2 Missing ⚠️
src/index.jsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
- Coverage   88.88%   88.28%   -0.60%     
==========================================
  Files         307      311       +4     
  Lines        5288     5379      +91     
  Branches     1345     1381      +36     
==========================================
+ Hits         4700     4749      +49     
- Misses        572      614      +42     
  Partials       16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

open-craft-grove · 2024-09-26T08:19:02Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-09-26T21:05:51Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-09-26T22:05:57Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-09-27T11:52:03Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

itsjeyd · 2024-11-07T09:08:12Z

Hey @qasimgulzar, just checking in to see if you're still planning to continue working on this PR?

open-craft-grove · 2024-11-07T10:35:00Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

itsjeyd · 2024-11-21T13:27:55Z

Hi @qasimgulzar! Just a quick update that I'm closing this PR now because it is stale. You're welcome to reopen this pull request, or open a new one, when you have time to come back to this work.

fix: Use Paragon Tab Component

05f985a

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 27, 2024

qasimgulzar mentioned this pull request Aug 27, 2024

Use Paragon Tab Component #1213

Open

fix: update the relevant routes

8cc7818

qasimgulzar marked this pull request as ready for review September 3, 2024 12:40

fix: remove console.log

82215a5

brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Sep 6, 2024

fix: broken DiscussionTab.test.jsx

ce82ded

bradenmacdonald reviewed Sep 24, 2024

View reviewed changes

itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 11, 2024

itsjeyd added the inactive PR author has been unresponsive for several months label Nov 7, 2024

itsjeyd closed this Nov 21, 2024

itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 21, 2024

itsjeyd added closed inactivity PR was closed because the author abandoned it and removed inactive PR author has been unresponsive for several months labels Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use Paragon Tab Component #1448

fix: Use Paragon Tab Component #1448

qasimgulzar commented Aug 27, 2024 •

edited

Loading

openedx-webhooks commented Aug 27, 2024 •

edited

Loading

open-craft-grove commented Sep 6, 2024

qasimgulzar commented Sep 6, 2024

itsjeyd commented Sep 7, 2024 •

edited

Loading

open-craft-grove commented Sep 15, 2024

qasimgulzar commented Sep 16, 2024

open-craft-grove commented Sep 16, 2024

itsjeyd commented Sep 20, 2024

open-craft-grove commented Sep 24, 2024

bradenmacdonald Sep 24, 2024

bradenmacdonald Sep 24, 2024

bradenmacdonald Sep 24, 2024

codecov bot commented Sep 24, 2024 •

edited

Loading

open-craft-grove commented Sep 26, 2024

open-craft-grove commented Sep 26, 2024

open-craft-grove commented Sep 26, 2024

open-craft-grove commented Sep 27, 2024

itsjeyd commented Nov 7, 2024

open-craft-grove commented Nov 7, 2024

itsjeyd commented Nov 21, 2024

fix: Use Paragon Tab Component #1448

fix: Use Paragon Tab Component #1448

Conversation

qasimgulzar commented Aug 27, 2024 • edited Loading

openedx-webhooks commented Aug 27, 2024 • edited Loading

What's next?

🔘 Get product approval

🔘 Provide context

🔘 Get a green build

🔘 Let us know that your PR is ready for review:

Who will review my changes?

Where can I find more information?

When can I expect my changes to be merged?

open-craft-grove commented Sep 6, 2024

qasimgulzar commented Sep 6, 2024

itsjeyd commented Sep 7, 2024 • edited Loading

open-craft-grove commented Sep 15, 2024

qasimgulzar commented Sep 16, 2024

open-craft-grove commented Sep 16, 2024

itsjeyd commented Sep 20, 2024

open-craft-grove commented Sep 24, 2024

bradenmacdonald Sep 24, 2024

Choose a reason for hiding this comment

bradenmacdonald Sep 24, 2024

Choose a reason for hiding this comment

bradenmacdonald Sep 24, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 24, 2024 • edited Loading

Codecov Report

open-craft-grove commented Sep 26, 2024

open-craft-grove commented Sep 26, 2024

open-craft-grove commented Sep 26, 2024

open-craft-grove commented Sep 27, 2024

itsjeyd commented Nov 7, 2024

open-craft-grove commented Nov 7, 2024

itsjeyd commented Nov 21, 2024

qasimgulzar commented Aug 27, 2024 •

edited

Loading

openedx-webhooks commented Aug 27, 2024 •

edited

Loading

itsjeyd commented Sep 7, 2024 •

edited

Loading

codecov bot commented Sep 24, 2024 •

edited

Loading