Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learner Dashboard has a broken skip link #510

Open
deborahgu opened this issue Nov 21, 2024 · 5 comments
Open

Learner Dashboard has a broken skip link #510

deborahgu opened this issue Nov 21, 2024 · 5 comments
Labels
a11y Relates to platform accessibility bug Report of or fix for something that isn't working as intended good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community

Comments

@deborahgu
Copy link
Member

description

frontend-component-header has, correctly, a Skip to main content link that goes to href=main. However, Learner dashboard has a main element with no ID, so the skip link fails. This is an accessibility issue; it's a violation of WCAG 2.4.1 (and is also just a broken link). This can almost certainly be easily fixed by adding id=main to the main element.

acceptance criteria

a keyboard or screen reader user who loads the page will have the first link be "Skip to main content", and activating that link should take the keyboard or screen reader focus to the primary block (for keyboard users it will be the "my courses" first reachable element, which I believe is the "refine" button; for screen reader users I believe there is the invisible announcement "learner home" followed by the rest of the "my courses" component).

@deborahgu deborahgu added bug Report of or fix for something that isn't working as intended good first issue A good task for a newcomer to start with a11y Relates to platform accessibility labels Nov 21, 2024
@deborahgu deborahgu moved this to Backlog in Aperture-Maintained Nov 21, 2024
@deborahgu deborahgu moved this from Backlog to Help Wanted in Aperture-Maintained Nov 21, 2024
@kdmccormick kdmccormick added the help wanted Ready to be picked up by anyone in the community label Nov 21, 2024
@Ankush1oo8
Copy link

Can I fix this issue

@MaxFrank13
Copy link
Member

Can I fix this issue

Please do! Feel free to assign yourself in the top right once you get started on it 🙂

@wittjeff
Copy link

You can see correct behavior on the Enterprise dashboard.
BTW there are still bugs with learning MFE skip links (first link jumps to the wrong place, second link, which is inside the content iframe, shouldn't appear at all on desktop, is there for use with webview in the mobile apps).

@Ankush1oo8
Copy link

I have tried to solve the issue, please if possible check it and let me know if there are mistakes in PR

@Ankush1oo8
Copy link

Please check PR #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Relates to platform accessibility bug Report of or fix for something that isn't working as intended good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community
Projects
Status: Help Wanted
Development

No branches or pull requests

5 participants