Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: ZendeskFab Component #496

Open
1 task
jsnwesson opened this issue Nov 13, 2024 · 2 comments
Open
1 task

[DEPR]: ZendeskFab Component #496

jsnwesson opened this issue Nov 13, 2024 · 2 comments
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21 needs maintainer attention Issue or PR specifically needs the attention of the maintainer.

Comments

@jsnwesson
Copy link
Contributor

jsnwesson commented Nov 13, 2024

Proposal Date

2024-11-13

Target Ticket Acceptance Date

2024-11-27

Earliest Open edX Named Release Without This Functionality

Teak - 2025-04

Rationale

The ZendeskFab component was created as part of a 2U/edX initiative and I don't believe it has been used by the community. The creators of the component have successfully replaced it using the frontend-plugin-framework. If the code is indeed unused, it only serves as a liability to the community and should be removed.

Removal

This is a proposal to remove the entire ZendeskFab directory and its sub-components, located at src/components/ZendeskFab.

This component is almost entirely decoupled from the rest of the Learner Dashboard application. Removing it shouldn't have any effect on the rest of the app configuration or view layout, as the ZendeskFab component is not rendered by default (since having been removed from the root App).

Note: the dependency react-zendesk will be uninstalled

Replacement

There is no intended replacement as this is presumably unused code.

Deprecation

No response

Migration

No response

Additional Info

@jsnwesson
Discourse Post
Closes #225

Task List

  • Remove ZendeskFab directory and sub-components
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Nov 13, 2024
@jsnwesson jsnwesson self-assigned this Nov 13, 2024
@jsnwesson jsnwesson moved this to In Progress in Aperture-Maintained Nov 13, 2024
@jsnwesson jsnwesson added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Nov 13, 2024
@jsnwesson jsnwesson moved this from Proposed to Communicated in DEPR: Deprecation & Removal Nov 13, 2024
@arbrandes
Copy link
Contributor

Big +1 from me!

@jsnwesson jsnwesson moved this from Communicated to Accepted in DEPR: Deprecation & Removal Dec 2, 2024
@jsnwesson
Copy link
Contributor Author

The acceptance time has expired with no questions or pushback, so I'm marking this DEPR as accepted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21 needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Status: In Progress
Status: Accepted
Development

No branches or pull requests

2 participants