Adding in remove capability for group members + csv download #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1367 +/- ##
==========================================
- Coverage 85.72% 85.53% -0.19%
==========================================
Files 609 611 +2
Lines 13363 13423 +60
Branches 2812 2812
==========================================
+ Hits 11455 11481 +26
- Misses 1838 1872 +34
Partials 70 70 ☔ View full report in Codecov by Sentry. |
| return `${year}-${month}-${day}-group-detail-report.csv`; | ||
| }; | ||
|
|
||
| const createCsvData = (jsonData) => jsonToCsv(jsonData.map(row => ({ |
There was a problem hiding this comment.
The issue with generating the csv file like this is that it can only generate a file with the current page of group member results.
If you want to take the client side approach, you can do it (prior art here) but you'll need to do another fetch of the data with page_size set to the total count of the filtered results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I'm going on Christmas break, this isn't a fully finished PR. It doesn't contain tests, nor does it have the filter functionality needed in the CSV download when a user searches a string or filters on something else.
For all changes
Only if submitting a visual change