Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding people management data table #1364

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Adding people management data table #1364

merged 5 commits into from
Dec 5, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Dec 4, 2024

Adding a card view members data table to the people management page
Screenshot 2024-12-04 at 10 00 23 AM

Figma | Jira ticket

Testing

https://localhost.stage.edx.org:1991/exec-ed-2u-integration-qa/admin/people-management
Search by name and email, look through pagination

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested a review from a team December 4, 2024 17:06
Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have one comment about the card rendering

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.72%. Comparing base (0c35ab3) to head (53581b3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/data/services/LmsApiService.js 14.28% 5 Missing and 1 partial ⚠️
...gement/data/hooks/useEnterpriseMembersTableData.js 80.76% 4 Missing and 1 partial ⚠️
src/components/PeopleManagement/OrgMemberCard.jsx 40.00% 3 Missing ⚠️
src/components/PeopleManagement/constants.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage   85.78%   85.72%   -0.07%     
==========================================
  Files         606      609       +3     
  Lines       13315    13363      +48     
  Branches     2762     2809      +47     
==========================================
+ Hits        11422    11455      +33     
- Misses       1825     1838      +13     
- Partials       68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit 371f043 into master Dec 5, 2024
4 of 6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9466 branch December 5, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants