-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding people management data table #1364
Conversation
src/components/PeopleManagement/data/hooks/useEnterpriseMembersTableData.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have one comment about the card rendering
aa7c2f7
to
53581b3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
- Coverage 85.78% 85.72% -0.07%
==========================================
Files 606 609 +3
Lines 13315 13363 +48
Branches 2762 2809 +47
==========================================
+ Hits 11422 11455 +33
- Misses 1825 1838 +13
- Partials 68 70 +2 ☔ View full report in Codecov by Sentry. |
Adding a card view members data table to the people management page
Figma | Jira ticket
Testing
https://localhost.stage.edx.org:1991/exec-ed-2u-integration-qa/admin/people-management
Search by name and email, look through pagination
For all changes
Only if submitting a visual change