Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add members data table to group detail page #1350

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

katrinan029
Copy link
Contributor

Description

Adds a group's data table with pending and registered learners.
https://www.figma.com/design/eMWRd2jVa4Jqc6y7qrUfaa/Groups-Phase-2?node-id=917-55910&t=sZoKuuNnNJvie0bI-1

https://2u-internal.atlassian.net/browse/ENT-9525

Testing

verify that you can filter by searching the member's email address and name, and sort the columns
verify that you see the member's enrollments, added date, and their name/email address

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review November 25, 2024 20:18
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (349cae2) to head (c588d0a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../data/hooks/useEnterpriseGroupLearnersTableData.js 67.74% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
- Coverage   85.80%   85.78%   -0.03%     
==========================================
  Files         600      604       +4     
  Lines       13222    13273      +51     
  Branches     2746     2792      +46     
==========================================
+ Hits        11345    11386      +41     
- Misses       1812     1819       +7     
- Partials       65       68       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little nits but overall looks good!

@katrinan029 katrinan029 merged commit 1a537e4 into master Dec 4, 2024
4 of 6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9525 branch December 4, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants