Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group selection to invite members modal #1344

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Nov 1, 2024

Description

Updates the members invite modal to include a dropdown menu with flex groups.
https://2u-internal.atlassian.net/browse/ENT-9490

UI Changes

Screenshot 2024-11-01 at 2 02 05 PM

Testing

  1. checkout branch knguyen2/ent-9490 and visit link https://localhost.stage.edx.org:1991/exec-ed-2u-integration-qa/admin/learner-credit/e259a8e5-e0ad-4c9d-bf14-9abf310158c7
  2. confirm that you see a dropdown menu
  3. select a group and confirm that the email populates in the summary section

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (4e72019) to head (1c2dbf9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nents/PeopleManagement/CreateGroupModalContent.jsx 89.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   85.73%   85.78%   +0.05%     
==========================================
  Files         597      598       +1     
  Lines       13071    13119      +48     
  Branches     2766     2774       +8     
==========================================
+ Hits        11206    11254      +48     
  Misses       1800     1800              
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 marked this pull request as ready for review November 1, 2024 21:06
@katrinan029 katrinan029 requested a review from a team November 1, 2024 21:06
@katrinan029 katrinan029 merged commit dfaa444 into master Nov 6, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9490 branch November 6, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants