Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lpr budgets filtering #1338

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

muhammad-ammar
Copy link
Contributor

@muhammad-ammar muhammad-ammar commented Oct 17, 2024

Description: Add support to filter LPR records by budget.
JIRA: https://2u-internal.atlassian.net/browse/ENT-9295
Dependency: openedx/edx-enterprise-data#522

Screenshots:
Screenshot 2024-10-17 at 11 54 24 AM

Screenshot 2024-10-17 at 11 54 31 AM Screenshot 2024-10-17 at 11 54 38 AM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@muhammad-ammar muhammad-ammar marked this pull request as draft October 17, 2024 06:57
@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-budgets-filtering branch 2 times, most recently from 16447f1 to 2fbec7e Compare October 22, 2024 10:43
@muhammad-ammar muhammad-ammar marked this pull request as ready for review October 22, 2024 10:57
@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-budgets-filtering branch from 2fbec7e to 2196651 Compare October 22, 2024 11:09
@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-budgets-filtering branch from 2196651 to 9cb29b0 Compare October 22, 2024 12:13
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.72%. Comparing base (888fb6b) to head (8a30273).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/AdminPage/index.jsx 50.00% 2 Missing ⚠️
src/data/actions/enterpriseBudgets.js 84.61% 2 Missing ⚠️
src/utils.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   85.70%   85.72%   +0.01%     
==========================================
  Files         591      594       +3     
  Lines       12924    12977      +53     
  Branches     2728     2748      +20     
==========================================
+ Hits        11077    11125      +48     
- Misses       1786     1791       +5     
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhammad-ammar muhammad-ammar marked this pull request as draft October 22, 2024 12:24
@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-budgets-filtering branch from f32ccb3 to 78cb995 Compare October 23, 2024 07:30
@muhammad-ammar muhammad-ammar marked this pull request as ready for review October 23, 2024 07:51
@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-budgets-filtering branch from 78cb995 to bf8351f Compare October 23, 2024 07:53
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-budgets-filtering branch from bf8351f to 8a30273 Compare October 23, 2024 10:15
@muhammad-ammar muhammad-ammar merged commit 4f9d197 into master Oct 23, 2024
6 checks passed
@muhammad-ammar muhammad-ammar deleted the ammar/lpr-budgets-filtering branch October 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants