Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ship analytics 2.0 #1332

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat: ship analytics 2.0 #1332

merged 1 commit into from
Nov 21, 2024

Conversation

muhammad-ammar
Copy link
Contributor

@muhammad-ammar muhammad-ammar commented Oct 9, 2024

Description: Disable Analytics V1 and enable Analytics V2.
JIRA: https://2u-internal.atlassian.net/browse/ENT-9242

Screenshot 2024-10-09 at 3 30 46 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@muhammad-ammar muhammad-ammar force-pushed the ammar/ship-analytics-v2 branch from 1711e38 to d7951e6 Compare October 9, 2024 10:53
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (9cecb0b) to head (bc2aad6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   85.58%   85.56%   -0.02%     
==========================================
  Files         601      601              
  Lines       13235    13234       -1     
  Branches     2793     2792       -1     
==========================================
- Hits        11327    11324       -3     
- Misses       1843     1845       +2     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jajjibhai008 jajjibhai008 force-pushed the ammar/ship-analytics-v2 branch from d7951e6 to 6323a7d Compare November 7, 2024 11:25
@jajjibhai008 jajjibhai008 force-pushed the ammar/ship-analytics-v2 branch from 6323a7d to a8f23f0 Compare November 14, 2024 12:22
@jajjibhai008 jajjibhai008 force-pushed the ammar/ship-analytics-v2 branch from a8f23f0 to bc2aad6 Compare November 21, 2024 13:13
@jajjibhai008 jajjibhai008 merged commit 5d259ea into master Nov 21, 2024
5 of 6 checks passed
@jajjibhai008 jajjibhai008 deleted the ammar/ship-analytics-v2 branch November 21, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants