-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds create group modal #1330
Conversation
bc5ff93
to
f393783
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1330 +/- ##
==========================================
+ Coverage 85.67% 85.71% +0.04%
==========================================
Files 578 581 +3
Lines 12730 12797 +67
Branches 2711 2718 +7
==========================================
+ Hits 10906 10969 +63
- Misses 1763 1767 +4
Partials 61 61 ☔ View full report in Codecov by Sentry. |
f393783
to
8e070c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple copy changes!
src/components/learner-credit-management/invite-modal/InviteSummaryCount.jsx
Outdated
Show resolved
Hide resolved
src/components/PeopleManagement/tests/CreateGroupModal.test.jsx
Outdated
Show resolved
Hide resolved
8e070c8
to
64da9c3
Compare
2896a42
to
4cd08d0
Compare
4cd08d0
to
8f207ca
Compare
Description
Adds a modal to create a group and assign members to the group.
TODO: We also need to add in logic to check if a user belongs to the org. refer to this JIRA Ticket
https://2u-internal.atlassian.net/browse/ENT-9600
Test
Test scenario 1
Test scenario 2
Test scenario 3
Test scenario 4
Screen.Recording.2024-10-07.at.3.55.26.PM.mov
For all changes
Only if submitting a visual change