Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds create group modal #1330

Merged
merged 3 commits into from
Oct 15, 2024
Merged

feat: adds create group modal #1330

merged 3 commits into from
Oct 15, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Oct 7, 2024

Description

Adds a modal to create a group and assign members to the group.

TODO: We also need to add in logic to check if a user belongs to the org. refer to this JIRA Ticket
https://2u-internal.atlassian.net/browse/ENT-9600

Test

  1. checkout branch knguyen2/ent9464
  2. npm run start:stage

Test scenario 1

  1. go to link https://localhost.stage.edx.org:1991/adam-autoapplied-enterprise/admin/people-management and verify that you can create a group while adding members through a csv upload
  2. confirm that the group was added in django admin screen

Test scenario 2

  1. go to link https://localhost.stage.edx.org:1991/adam-autoapplied-enterprise/admin/people-management and verify that the Create button is disabled if there is no group name or valid emails

Test scenario 3

  1. go to link https://localhost.stage.edx.org:1991/adam-autoapplied-enterprise/admin/people-management and verify that the Create button is disabled if there is a group name but no valid emails

Test scenario 4

  1. go to link https://localhost.stage.edx.org:1991/adam-autoapplied-enterprise/admin/people-management and verify that the Create button is disabled if there is no group name but has valid emails
Screen.Recording.2024-10-07.at.3.55.26.PM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 94.36620% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.71%. Comparing base (912940c) to head (d24125e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...dit-management/invite-modal/InviteModalContent.jsx 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
+ Coverage   85.67%   85.71%   +0.04%     
==========================================
  Files         578      581       +3     
  Lines       12730    12797      +67     
  Branches     2711     2718       +7     
==========================================
+ Hits        10906    10969      +63     
- Misses       1763     1767       +4     
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 marked this pull request as ready for review October 7, 2024 22:56
@katrinan029 katrinan029 requested a review from a team October 7, 2024 22:56
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple copy changes!

@katrinan029 katrinan029 changed the title feat: adds create group modal feat: adds create group modal Oct 11, 2024
@katrinan029 katrinan029 merged commit 06c0a56 into master Oct 15, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent9464 branch October 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants