Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9538] Fixed index mapping for scatter chart #1327

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mahamakifdar19
Copy link
Contributor

Ticket
https://2u-internal.atlassian.net/browse/ENT-9538

Description
Fixed index mapping for scatter chart. Updated the method to derive the index from the original data array instead of filteredData to ensure correct marker sizes.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (b06faa9) to head (50d46f4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   85.61%   85.62%           
=======================================
  Files         576      576           
  Lines       12697    12700    +3     
  Branches     2693     2649   -44     
=======================================
+ Hits        10871    10874    +3     
- Misses       1765     1766    +1     
+ Partials       61       60    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit e3b1452 into master Oct 3, 2024
6 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-9538-index-fix branch October 3, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants