Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: summarize analytics for demo data #1175

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

muhammad-ammar
Copy link
Contributor

@muhammad-ammar muhammad-ammar commented Feb 22, 2024

JIRA: https://2u-internal.atlassian.net/browse/ENT-8296

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbd64d7) 85.34% compared to head (9ee0938) 85.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1175   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         497      497           
  Lines       10829    10830    +1     
  Branches     2282     2282           
=======================================
+ Hits         9242     9243    +1     
  Misses       1543     1543           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhammad-ammar muhammad-ammar merged commit e480802 into master Feb 22, 2024
6 checks passed
@muhammad-ammar muhammad-ammar deleted the ammar/lpr-fix-summarize-analytics branch February 22, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants