fix: course about URL should use course key, not course run key. #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 497 497
Lines 10839 10839
Branches 2283 2283
=======================================
Hits 9251 9251
Misses 1544 1544
Partials 44 44 ☔ View full report in Codecov by Sentry. |
pwnage101
force-pushed
the
pwnage101/ENT-8389
branch
2 times, most recently
from
0a3b247 to
bf88df2
Compare
adamstankiewicz
approved these changes
Feb 21, 2024
pwnage101
force-pushed
the
pwnage101/ENT-8389
branch
4 times, most recently
from
94d224c to
46b14b8
Compare
When the spent table was first implemented, it utilized the Analytics API to fetch enrollments, and that data source contained a course key field. However, when we switched over to real-time fetching of redemptions via the transaction list API for assignable budgets, we erroneously treated the `content_key` field as a course key, breaking the course about page link in the spent table. The following two PRs implment a `parent_content_key` field in the transaction list API, which we can now utilize for the real-time spent table implmentation: * openedx/openedx-ledger#60 * openedx/enterprise-subsidy#209 ENT-8389
pwnage101
force-pushed
the
pwnage101/ENT-8389
branch
from
46b14b8 to
11cf3f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the spent table was first implemented, it utilized the Analytics API to fetch enrollments, and that data source contained a course key field. However, when we switched over to real-time fetching of redemptions via the transaction list API for assignable budgets, we erroneously treated the
content_keyfield as a course key, breaking the course about page link in the spent table.The following two PRs implment a
parent_content_keyfield in the transaction list API, which we can now utilize for the real-time spent table implmentation:parent_content_keyto transaction when redeeming content enterprise-subsidy#209ENT-8389
For all changes
Only if submitting a visual change