fix: block events for missing courses #355
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Ian2012
force-pushed
the
cag/missing-courses
branch
from
057ae74 to
d10cc1f
Compare
Ian2012
changed the title
| return { | ||
| "display_name": "Unknown Course", | ||
| } | ||
| raise ValueError(f"Course with id {course_id} does not exist.") |
There was a problem hiding this comment.
Can't remember, will this be caught upstream so it doesn't break bulk export?
There was a problem hiding this comment.
The only helper that raises an exception is get_anonymous_user_id and it raises a ValueError exception. It shouldn't break the workflow.
@ziafazal Am I right?
Ian2012
force-pushed
the
cag/missing-courses
branch
from
d10cc1f to
e48b7c0
Compare
Ian2012
changed the title
|
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description: A setting to allow to send missing courses
JIRA: Link to JIRA ticket
Dependencies: dependencies on other outstanding PRs, issues, etc.
Merge deadline: List merge deadline (if any)
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.