Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: extract sqldb generation in repo health job as artifact #430

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Oct 24, 2023

Description

  • PR created under the issue Fix sqlite db update action in repo health job #405
  • This PR modifies the repo-health-job script to skip generating the sqlite3 db file which was previously being committed to the repository.
  • After this change, a new script repo-health-artifact gets triggered to generate sqlite3 db file separately from the yaml files committed to the repository by the repo health workflow build.

Testing

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da64bcd) 81.72% compared to head (1fd8902) 81.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   81.72%   81.72%           
=======================================
  Files          24       24           
  Lines        1302     1302           
=======================================
  Hits         1064     1064           
  Misses        238      238           
Flag Coverage Δ
unittests 81.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@UsamaSadiq UsamaSadiq requested a review from jmbowman October 26, 2023 13:26
@UsamaSadiq UsamaSadiq force-pushed the extract-repo-health-job-sqldb-creation branch 3 times, most recently from db68b13 to 238ba36 Compare November 23, 2023 10:29
@UsamaSadiq UsamaSadiq force-pushed the extract-repo-health-job-sqldb-creation branch from 238ba36 to 2e02442 Compare December 4, 2023 10:06
@UsamaSadiq UsamaSadiq requested a review from jmbowman December 4, 2023 10:38
@UsamaSadiq UsamaSadiq force-pushed the extract-repo-health-job-sqldb-creation branch from 8c84cb8 to 1fd8902 Compare December 13, 2023 12:33
@UsamaSadiq UsamaSadiq merged commit d5a7400 into master Dec 14, 2023
6 checks passed
@UsamaSadiq UsamaSadiq deleted the extract-repo-health-job-sqldb-creation branch December 14, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants