Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update fake package.json to reduce confusion. #427

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Oct 19, 2023

I didn't update the package-lock.json because it looks like that is not
generated from this file in the test repos to begin with.

I didn't update the package-lock.json because it looks like that is not
generated from this file in the test repos to begin with.
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (48efde9) 82.09% compared to head (f5fd417) 81.72%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   82.09%   81.72%   -0.38%     
==========================================
  Files          24       24              
  Lines        1296     1302       +6     
==========================================
  Hits         1064     1064              
- Misses        232      238       +6     
Flag Coverage Δ
unittests 81.72% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running npm install in both of these directories on master and it failed so I'm assuming not updating package-lock.json is fine.

:shipit:

@feanil feanil merged commit 7875594 into master Oct 19, 2023
4 of 5 checks passed
@feanil feanil deleted the feanil/upgrade_brand branch October 19, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants