fix: renovate check last pr issue #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
==========================================
- Coverage 82.09% 81.72% -0.38%
==========================================
Files 24 24
Lines 1296 1302 +6
==========================================
Hits 1064 1064
- Misses 232 238 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Syed-Ali-Abbas-Zaidi
force-pushed
the
Ali-Abbas/fix-renovate-last-pr-check
branch
2 times, most recently
from
e08b93d to
74f9bd0
Compare
Syed-Ali-Abbas-Zaidi
force-pushed
the
Ali-Abbas/fix-renovate-last-pr-check
branch
from
74f9bd0 to
05dce90
Compare
awais786
approved these changes
Oct 18, 2023
|
its failing on coverage. |
That's because these functions are mocked in unit tests. So the existing code inside these functions is already uncovered by test cases and any new addition to these functions also remains uncovered, which causes the failure of coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the renovate
Last PRcheck is not working properly for the openedx repos. This PR fixes the issue related to the renovate check.Merge checklist: