chore: allow custom log formatter #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawoudSheraz
reviewed
Dec 6, 2024
| @@ -24,6 +24,8 @@ | |||
| # the values read from disk should UPDATE the pre-configured dicts. | |||
| DICT_UPDATE_KEYS = ('JWT_AUTH',) | |||
|
|
|||
| LOGGING_FORMAT_STRING = '' | |||
There was a problem hiding this comment.
should this be empty in production.py?
There was a problem hiding this comment.
did you mean to set this in base.py?
There was a problem hiding this comment.
No. Though I have done it now. It should work either way.
DawoudSheraz
reviewed
Dec 6, 2024
| 'format': '%(asctime)s %(levelname)s %(process)d ' | ||
| '[%(name)s] %(filename)s:%(lineno)d - %(message)s', | ||
| 'format': LOGGING_FORMAT_STRING or '%(asctime)s %(levelname)s %(process)d ' | ||
| '[%(name)s] %(filename)s:%(lineno)d - %(message)s' |
There was a problem hiding this comment.
nit: why is this tabbed space added?
There was a problem hiding this comment.
Just to align the lower part of the string with the top
DawoudSheraz
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4241
This PR adds a new settings variable to configure the way logs are formatted