-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added meilisearch dependency and fixt index creation #4381
feat: added meilisearch dependency and fixt index creation #4381
Conversation
Thanks for the pull request, @qasimgulzar! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
feat: integrate django_meili
4311b13
to
d0f247d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qasimgulzar Can you please update this PR to provide more details? I don't understand how this works, what it's for, or how to test it. Does this allow replacing ElasticSearch with Meilisearch or is this just sending some data to a Meilisearch index, but not using that data?
'HTTPS': False, # Whether HTTPS is enabled for the meilisearch server | ||
'HOST': 'meilisearch', # The host for the meilisearch server | ||
'MASTER_KEY': 'masterKey', | ||
# The master key for meilisearch. See https://www.meilisearch.com/docs/learn/security/basic_security for more detail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should recommend using the master key for this sort of thing.
HI @qasimgulzar! Is this pull request still in progress? |
Closing for now, due to inactivity. Can reopen if needed. |
Added django_meili into discovery to push data to meilisearch. below is a exmaple of command to push data
./manage.py syncindex course_metadata.ProgramProxy
Settings