Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tox<4.0.0 to containts.txt #277

Merged
merged 3 commits into from
Oct 25, 2023
Merged

chore: Add tox<4.0.0 to containts.txt #277

merged 3 commits into from
Oct 25, 2023

Conversation

ZiqiXiao
Copy link
Contributor

Add tox<4.0.0 to containts.txt for public-engineering#217

Reviewers:

Add tox<4.0.0 to containts.txt for public-engineering#217
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 22, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ZiqiXiao! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@feanil
Copy link
Contributor

feanil commented Oct 23, 2023

@ZiqiXiao did you run make upgrade after you constraints change? I realized after the review of the other PR that there will be changes in other requirements files based on the change in the constraints file.

@ZiqiXiao
Copy link
Contributor Author

ZiqiXiao commented Oct 24, 2023

@ZiqiXiao did you run make upgrade after you constraints change? I realized after the review of the other PR that there will be changes in other requirements files based on the change in the constraints file.

No. I didn't run that check. I will do it and let you know the result.

@feanil I run make upgrade, there are indeed some requirements files changed. I will make make a new pull request after running make upgrade. And I will check api-doc-tools, which I created a PR and was merged already, to make sure changed files are included and create a new PR.

Run make upgrade and files are updated.
Rerun make upgrade with Python 3.8.
@ZiqiXiao
Copy link
Contributor Author

@feanil I have rerun make upgrade with Python 3.8 please review it. Thx👀

@feanil feanil merged commit 624815b into openedx:master Oct 25, 2023
4 checks passed
@openedx-webhooks
Copy link

@ZiqiXiao 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants