-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aggregated vote value is not updated till refresh #83
base: master
Are you sure you want to change the base?
The head ref may contain hidden characters: "romaniuk/fix/aggregated-vote-value-is-not\u2013updated-till-refresh"
fix: aggregated vote value is not updated till refresh #83
Conversation
Thanks for the pull request, @ihor-romaniuk! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 92.47% 92.85% +0.37%
==========================================
Files 5 5
Lines 226 224 -2
==========================================
- Hits 209 208 -1
+ Misses 17 16 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@openedx/axim-engineering - is this something we can review / merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ihor-romaniuk this PR mixes styling changes with the actual changes you're trying to make, happy to take them both but I think they should be atleast separate commits so that it's easier to review the technical changes. Can you either split them or remove the style changes so that it's easier to review the logical change?
Description
This pull request contains minor code refactoring and fix for aggregated vote value is not updated till refresh.
Steps to Reproduce:
Expected Result:
Value is updated after click