Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responsive for mobile devices #84

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ihor-romaniuk
Copy link
Contributor

Description

This pull request contains minor style refactoring and fix for responsive in the LMS.

Actual Result:

Feedback is not fully displayed

image image

Expected Result:

Feedback is adaptive and fully displayed

image image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 3, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 3, 2024

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/axim-engineering. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (ab0bd00) to head (e1171ed).
Report is 59 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files           5        5           
  Lines         226      226           
=======================================
  Hits          209      209           
  Misses         17       17           
Flag Coverage Δ
unittests 92.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ihor-romaniuk
Copy link
Contributor Author

Hello everyone,
It seems our pull request for the fix might be a bit stuck in the review process. Would someone be able to take a look at it when they have a moment?
Thank you so much for your time and help!

@mphilbrick211
Copy link

Hello everyone, It seems our pull request for the fix might be a bit stuck in the review process. Would someone be able to take a look at it when they have a moment? Thank you so much for your time and help!

@openedx/axim-engineering

@feanil feanil requested a review from a team December 10, 2024 21:32
@feanil
Copy link
Contributor

feanil commented Dec 10, 2024

@mphilbrick211 I've asked @openedx/axim-aximprovements to take a look at this change.

Copy link
Member

@irtazaakram irtazaakram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally. LGTM 👍🏻

@irtazaakram irtazaakram merged commit 103a2b4 into openedx:master Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants