Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add star icon set #37

Merged
merged 1 commit into from
Dec 1, 2023
Merged

feat: add star icon set #37

merged 1 commit into from
Dec 1, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Nov 1, 2023 •
edited
Loading

Description

This PR adds a new star icon set:

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 1, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3eababa) 90.78% compared to head (e671eea) 90.78%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files           1        2    +1     
  Lines         141      141           
=======================================
  Hits          128      128           
  Misses         13       13
Flag Coverage Δ
unittests 90.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ian2012 Ian2012 requested review from OmarIthawi, feanil and farhan and removed request for OmarIthawi November 1, 2023 21:58
@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 16, 2023

@feanil would you like to leave some feedback?

feanil
feanil reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments, I'll test this further soon hopefully.

feedback/feedback.py Outdated Show resolved Hide resolved
feedback/public/default_icons/istar1.png Outdated Show resolved Hide resolved
feedback/templates/html/studio_view.html Outdated Show resolved Hide resolved
farhan
farhan requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a query and a change request

feedback/feedback.py Show resolved Hide resolved
feedback/feedback.py Show resolved Hide resolved
@Ian2012 Ian2012 requested a review from farhan November 20, 2023 15:51
@farhan
Copy link
Contributor

farhan commented Nov 24, 2023

Experiencing following UI change after changes in the following css in this PR
feedback/static/css/feedback.css
I tested it directly on the xblock-sdk, don't know how it appears in the course.

Before After
before after

@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 24, 2023

@farhan corrected. Unnecessary CSS rules has been removed

@farhan
Copy link
Contributor

farhan commented Nov 27, 2023

@farhan corrected. Unnecessary CSS rules has been removed

screencapture-127-0-0-1-8000-scenario-feedback-0-2023-11-27-10_43_26

I think all stars should appear in a row, did you test it on LMS view?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 27, 2023

@farhan It's corrected now:

image

farhan
farhan requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ian2012 Change looks good now
Fix the test case and let's merge this PR

@Ian2012
feat: add star icon set
e671eea 
chore: remove unused selected images

style: replace inline css

refactor: quality fixes

fix: add missing new star text

chore: improve star icons

fix: remove whitespace

Co-authored-by: Feanil Patel <[email protected]>

chore: quality checks

fix: remove unused width

fix: restore width constraint
@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 30, 2023

@farhan ready to be merged

@farhan farhan merged commit 17126d0 into openedx:master Dec 1, 2023
5 checks passed
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil left review comments

@farhan farhan farhan requested changes

Assignees

@farhan farhan

Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Aximprovements Team
Archived in project
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ian2012 @openedx-webhooks @farhan @feanil